provider/aws: repository_url is computed for aws_ecr_repository

[stack72]

As requested in #5518, we can compute the repository_url for ECR using a known format:

https://aws_account_id.dkr.ecr.region.amazonaws.com/repositoryName

ake testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcrRepository_basic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcrRepository_basic -timeout 120m
=== RUN   TestAccAWSEcrRepository_basic
--- PASS: TestAccAWSEcrRepository_basic (6.97s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    6.983s

FYI, I didn't want to hardcode an account_id into the tests :)

But when I run this locally, I get the following output:

STATE:

aws_ecr_repository.default:
  ID = foo-repository-terraform
  arn = arn:aws:ecr:us-east-1:<ID>:repository/foo-repository-terraform
  name = foo-repository-terraform
  registry_id = <ID>
  repository_url = https://<ID>.dkr.ecr.us-east-1.amazonaws.com/foo-repository-terraform

[radeksimko]

It would be nice to make this function less greedy in terms of arguments. e.g.

func buildRepositoryUrl(repo *ecr.Repository, region string) string {

[radeksimko]

Besides the nitpick with arguments this LGTM.

[stack72]

@radeksimko made the change as requested. Makes sense :) Will merge when it goes green!

[jim3ma]

please removing the https:// part, the https:// will cause 500 for ecs agent

[jim3ma]

Why https ? just return fmt.Sprintf("%s.dkr.ecr.%s.amazonaws.com/%s", *repo.RegistryId, region, *repo.RepositoryName) is okay!

[hndrewaall]

I have the same issue. I'd like to use this in a container definition template and the HTTPS breaks it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.