Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws validate number of load_balancers before creating aws_ecs_service #5605

Merged
merged 1 commit into from
Mar 13, 2016
Merged

provider/aws validate number of load_balancers before creating aws_ecs_service #5605

merged 1 commit into from
Mar 13, 2016

Conversation

nicolai86
Copy link
Contributor

this PR is fixing the issue detailed in #5336

@radeksimko
Copy link
Member

Hi @nicolai86
I think that a cleaner solution for this would be to use MaxItems: 1 which was introduced recently in #5218

Would you mind modifying the PR?

Thanks.

@radeksimko radeksimko added enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community labels Mar 13, 2016
@nicolai86
Copy link
Contributor Author

@radeksimko thanks for pointing that out! I'm still working on finding my way around the terraform codebase so that tip is greatly appreciated! Fixed!

@radeksimko radeksimko removed the waiting-response An issue/pull request is waiting for a response from the community label Mar 13, 2016
@radeksimko
Copy link
Member

Ta 👍

radeksimko added a commit that referenced this pull request Mar 13, 2016
provider/aws validate number of load_balancers before creating aws_ecs_service
@radeksimko radeksimko merged commit 189e9b5 into hashicorp:master Mar 13, 2016
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants