Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: optional fields in aws_autoscaling_lifecycle_hook #5616

Merged
merged 1 commit into from
Mar 14, 2016
Merged

provider/aws: optional fields in aws_autoscaling_lifecycle_hook #5616

merged 1 commit into from
Mar 14, 2016

Conversation

pcarrier
Copy link
Contributor

For #5614

@stack72
Copy link
Contributor

stack72 commented Mar 14, 2016

thanks for the change here @pcarrier :) LGTM!

stack72 added a commit that referenced this pull request Mar 14, 2016
…ycle_hook_optional

provider/aws: optional fields in aws_autoscaling_lifecycle_hook
@stack72 stack72 merged commit cea8602 into hashicorp:master Mar 14, 2016
@stack72
Copy link
Contributor

stack72 commented Mar 14, 2016

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAutoscalingLifecycleHook' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAutoscalingLifecycleHook -timeout 120m
=== RUN   TestAccAWSAutoscalingLifecycleHook_basic
--- PASS: TestAccAWSAutoscalingLifecycleHook_basic (167.86s)
=== RUN   TestAccAWSAutoscalingLifecycleHook_omitDefaultResult
--- PASS: TestAccAWSAutoscalingLifecycleHook_omitDefaultResult (199.93s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    367.806s

@pcarrier pcarrier deleted the pcarrier/aws_autoscaling_lifecycle_hook_optional branch March 14, 2016 12:39
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants