Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required target_id param in aws_cloudwatch_event_target #5702

Closed
iceycake opened this issue Mar 18, 2016 · 5 comments
Closed

Required target_id param in aws_cloudwatch_event_target #5702

iceycake opened this issue Mar 18, 2016 · 5 comments

Comments

@iceycake
Copy link
Contributor

The target_id looks like an arbitrary id to guarantee the unique of the event rule target. Should it be a computed schema instead of a required schema?

@radeksimko
Copy link
Member

Hi @iceycake

The target_id looks like an arbitrary id to guarantee the unique of the event rule target.

TargetId/target_id is quite important part of the resource, see https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_cloudwatch_event_target.go#L177-L196

I don't think there is any way we can compute/generate this - correct me if I'm wrong.

@radeksimko radeksimko added the waiting-response An issue/pull request is waiting for a response from the community label Mar 18, 2016
@iceycake
Copy link
Contributor Author

May be it is just me or the documentation. What's does the target_id do? I can't find it in AWS documentation. In the go code, I see id = rule + "-" + target_id

@radeksimko radeksimko removed the waiting-response An issue/pull request is waiting for a response from the community label Mar 18, 2016
@radeksimko
Copy link
Member

@iceycake Sorry, I initially mixed this up with arn, so I'm taking back the words about the importance.

It is documented here:
http://docs.aws.amazon.com/AmazonCloudWatchEvents/latest/APIReference/API_Target.html

Id
The unique target assignment ID.
Type: String
Length constraints: Minimum length of 1. Maximum length of 64.
Pattern: [\.\-_A-Za-z0-9]+
Required: Yes

It says Required, but as you said it doesn't probably do anything except guaranteeing uniqueness.

I think we could make it optional and automatically generated. PRs welcomed 😉

@stack72
Copy link
Contributor

stack72 commented Mar 31, 2016

Merged in #5787

@stack72 stack72 closed this as completed Mar 31, 2016
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants