Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: aws_redshift_cluster now allowspublicly_accessible to be modified #5721

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Mar 18, 2016

Fixes #5540

Also updated the AWS Go SDK from 1.1.9 -> 1.1.12 as this was required to
allow the new behavior for the Redshift API

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_basic
--- PASS: TestAccAWSRedshiftCluster_basic (651.26s)
=== RUN   TestAccAWSRedshiftCluster_publiclyAccessible
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (752.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1403.431s

`publicly_accessible` to be changed

Also updated the AWS Go SDK from 1.1.9 -> 1.1.12 as this was required to
allow the new behavior for the Redshift API
@phinze
Copy link
Contributor

phinze commented Mar 18, 2016

LGTM

stack72 added a commit that referenced this pull request Mar 18, 2016
provider/aws: `aws_redshift_cluster` now allows`publicly_accessible` to be modified
@stack72 stack72 merged commit f2fb5d6 into hashicorp:master Mar 18, 2016
@stack72 stack72 deleted the f-aws-redshift-modify branch March 18, 2016 20:02
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/aws: Change publicly_accessible in Redshift to not be ForceNew
3 participants