provider/aws: Convert protocols to standard format for Security Groups #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert network protocols to their names for keys/state, fixing issue(s) when using them interchangeably.
|
This is a great find @catsby :) Will be good to close off this issue LGTM! |
|
|
||
| resource "aws_security_group" "web" { | ||
| name = "terraform_acceptance_test_example" | ||
| description = "Used in the terraform acceptance tests" |
There was a problem hiding this comment.
I think it's better to omit these to protect us against future collision - let the tags stick around for taxonomy purposes.
|
Looking solid so far!
|
|
Discussed |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert network protocols to their names for keys/state in Security Group and Security Group Rules, fixing issue(s) when using them interchangeably.
Fixes issues like #5050 where there is a mix and match of using
"6"and"tcp"for theprotocolvalue. The name/number reference can be found here:We support a limited set of those, as defined/leveraged from https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/network_acl_entry.go#L81
Right now, if a user specifies
"17"for the protocol (the code forupd), they'll get a diff error when they plan/apply. This is because the AWS API will accept the code or number, but will automatically convert numbers to their matching code, e.g. send17and getudpback, except for-1which representsall. If you send-1, you get-1back.In this PR we convert all of the numbers referenced in the
network_acl_entry.gomethod to their proper name for hashing. Users can use them interchangeably. I've added a statefunc for both Security Groups and Security Group Rules, and double checked our existing tests to make sure there aren't any stray6or other non-string protocols used.Both
TestAccAWSSecurityGroupRule_Ingress_Protocolinsecurity_group_rule_test.go, and the simple"tcp"->"6"insecurity_group_test.goare regression tests; they would fail on master.