provider/aws: DB subnet group description modification

[ColinHebert]

Do not force a new resource when changing the description of a db subnet group

[stack72]

Hi @ColinHebert

This change will indeed mean that when a change is made, that it doesn't force a new subnet group BUT this change will not actually change the description

You would need to include the work here to change the subnet net group description as part of the resourceAwsDbSubnetGroupUpdate func for the changes to actually be pushed to AWS

If you need any pointers here, please do let me know

Paul

[ColinHebert]

Arg, you are correct, those are the little assumptions that come back and catch you... Anyway, I added the description to the update query (cf. ModifyDBSubnetGroupInput in https://github.com/aws/aws-sdk-go/blob/master/service/rds/api.go)

[stack72]

Hi @ColinHebert

This will only actually be called if there is a chance in subnet_ids

This update will need to be reworked. I will manually make those changes on the PR and test it.

[ColinHebert]

Fixed, added the HasChange on description as well. In the case where the subnet_ids do not change but description does change, the GetChange method is expected to still return the desired value (as it hasn't changed) for the update.

[stack72]

Hi @ColinHebert

This looks good - thanks for the work here :) Merging now as tests are green :)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBSubnetGroup' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBSubnetGroup -timeout 120m
=== RUN   TestAccAWSDBSubnetGroup_basic
--- PASS: TestAccAWSDBSubnetGroup_basic (20.76s)
=== RUN   TestAccAWSDBSubnetGroup_withUndocumentedCharacters
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (21.65s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    43.211s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.