Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for cname_prefix to aws_elastic_beanstalk_environment resource. #5966

Merged

Conversation

dharrisio
Copy link
Contributor

Adds support for setting cname_prefix. This also sets 'WebServer' as the default tier type, which is consistent with the Elastic Beanstalk API when tier is omitted. This cleans up the check to make sure cname_prefix is not being set for a 'Worker' tier, which does not support cname_prefix.

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSBeanstalkEnv_cname_prefix -timeout 120m
=== RUN   TestAccAWSBeanstalkEnv_cname_prefix
--- PASS: TestAccAWSBeanstalkEnv_cname_prefix (349.97s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    349.979s

@stack72
Copy link
Contributor

stack72 commented Apr 1, 2016

Hi @dharrisio

thanks for the PR here - can you rebase this now that the wait_for_timeout PR has been merged :)

thanks

Paul

@dharrisio dharrisio force-pushed the f-aws-elastic-beanstalk-cname-prefix branch from d016404 to bb1d4ee Compare April 1, 2016 15:54
@dharrisio
Copy link
Contributor Author

@stack72 This has been rebased.

Thanks!

@catsby
Copy link
Contributor

catsby commented Apr 1, 2016

Thanks!

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants