Added Group attribute to cloudstack instance resource

[jefflaplante]

In our Cloudstack environment we make use of the group attribute. I noticed it was missing from the Terraform resource yet exists in the go-cloudstack library Terraform is using. This is simply an attribute addition so that the group may be specified in Terraform.

[svanharmelen]

@jefflaplante thanks for the PR!

If we add this attribute, I guess we also need to read back the group a VM belongs so we can make sure TF will keep us in the desired state if anything changes. And also we should be able to update the group if we want it to change right?

Lastly it would be great if you could also add a line to the docs to describe this new attribute. If you need help with all this, then just let me know!

[jefflaplante]

@svanharmelen Thanks for looking at my PR. I've added to the docs for this attribute and also augmented the read and update functions to support the group attribute.

[svanharmelen]

@jefflaplante looks good! One more question... Does that API need the group name, of the group ID?

And could you rebase the PR so it can be merged? Thx!

[svanharmelen]

@jefflaplante if you have time to answer that last question and do a rebase, I guess we can land this one so it ends up in the coming 0.6.15 release...

[svanharmelen]

@jefflaplante wanted to move forward with this one so checked the expected input which was indeed only accepting a group name and not also the ID. So since that one was OK, I went along and fixed your merge conflicts in order to be able to merge your commits...

So all in done and it will be in the next TF release 😉 Thanks!

[jefflaplante]

Thanks @svanharmelen! I got a bit bogged down in some other work. I appreciate you merging my commits. :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.