Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding privacy argument for GitHub teams for #6015 #6116

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

JacobASeverson
Copy link
Contributor

Added the ability to set the privacy of a github_team resource so all teams won't automatically set to private.

  • Added the privacy argument to github_team
  • Refactored parameter validation to be general for any argument
  • Updated testing

Added the ability to set the "privacy" of a github_team resource so all teams won't automatically set to private.

* Added the privacy argument to github_team

* Refactored parameter validation to be general for any argument

* Updated testing
@stack72
Copy link
Contributor

stack72 commented Apr 11, 2016

Hi @JacobASeverson

This LGTM! Thanks for the PR :)

Paul

@stack72 stack72 merged commit 7721348 into hashicorp:master Apr 11, 2016
@JacobASeverson JacobASeverson deleted the team_privacy branch April 11, 2016 14:53
chrislovecnm pushed a commit to chrislovecnm/terraform that referenced this pull request Apr 16, 2016
…p#6116)

Added the ability to set the "privacy" of a github_team resource so all teams won't automatically set to private.

* Added the privacy argument to github_team

* Refactored parameter validation to be general for any argument

* Updated testing
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants