Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Triton firewall_enabled bug with AccTest #6119

Merged
merged 3 commits into from
Apr 12, 2016
Merged

Fixes Triton firewall_enabled bug with AccTest #6119

merged 3 commits into from
Apr 12, 2016

Conversation

sodre
Copy link
Contributor

@sodre sodre commented Apr 11, 2016

This is to close #6109.

I am setting it to [WIP] because I am not sure what is the proper way of integrating the PR#23 to the vendor library .

The tests passed when I checked

$ make testacc TEST=./builtin/providers/triton/ TESTARGS='-run=TestAccTritonMachine_firewall'
==> Checking that code complies with gofmt requirements...
/Users/sodre/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/triton/ -v -run=TestAccTritonMachine_firewall -timeout 120m
=== RUN   TestAccTritonMachine_firewall
--- PASS: TestAccTritonMachine_firewall (116.74s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/triton 116.757s
$

@sodre
vendor: capture joyent/gosdc PR #23
2a54f05
@sodre
AccTest for Triton firewall_enabled property
73ab346 
Test does the minimum described in #6109, i.e.
	- Start a small instance, t4-standard-128M
	- Check firewall is enabled
	- Change configuration to disable firewall
	- Check firewall is disabled.
@sodre
Firewall Enable/Disable is an async call
7be7462
@sodre sodre changed the title Fixes Triton firewall_enabled bug with AccTest [WIP] Fixes Triton firewall_enabled bug with AccTest Apr 11, 2016
@misterbisson
Copy link

Thank you @sodre for seeing this through. TritonDataCenter/gosdc#23 is merged.

@misterbisson misterbisson mentioned this pull request Apr 12, 2016
Merged
@jen20
Copy link
Contributor

jen20 commented Apr 12, 2016

This LGTM! Thanks @sodre!

@jen20 jen20 merged commit 4a6e161 into hashicorp:master Apr 12, 2016
@jen20 jen20 mentioned this pull request Apr 12, 2016
Closed
@sodre sodre changed the title [WIP] Fixes Triton firewall_enabled bug with AccTest Fixes Triton firewall_enabled bug with AccTest Apr 12, 2016
@sodre sodre deleted the b-triton-machine-firewall branch April 12, 2016 22:04
chrislovecnm pushed a commit to chrislovecnm/terraform that referenced this pull request Apr 16, 2016
@sodre @chrislovecnm
Fix Triton firewall_enabled bug with AccTest (hashicorp#6119)
91f9bdb 
Update github.com/joyent/gosdc/...

Test does the minimum described in hashicorp#6109, i.e.
	- Start a small instance, t4-standard-128M
	- Check firewall is enabled
	- Change configuration to disable firewall
	- Check firewall is disabled.

Fixes hashicorp#6119.
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/triton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Triton Provider: firewall_enabled flag is always false
4 participants
@sodre @misterbisson @jen20 @stack72