core: fix provider config inheritence for deeply nested modules

[phinze]

The flattening process was not properly drawing dependencies between provider
nodes in modules and their parent provider nodes.

Fixes #2832
Fixes #4443
Fixes #4865

[jen20]

The build failure (terraform/transform_provider.go:357: undefined: prefix) seems related to this?

[jen20]

@phinze looks like the build error here is correct and there is a stray deletion in the diff?

[phinze]

Yeah final pre-push cleanup was a little overzealous - fixing! 😄

[phinze]

Ok green now, @jen20 PTAL!

[jen20]

This LGTM now.

[evilezh]

There is still bug with nested modules (0.6.16)
After I've created module, I did comment out it (so it should get destroyed).
here is structure:
root level: AWS defined, include of module level 2.
level 2: include several modules from level 3 (nothing else)
level 3: do aws stuff

When I ask to destroy:

terraform apply

provider.aws.region
The region where AWS operations will take place. Examples
are us-east-1, us-west-2, etc.

Default: us-east-1
Enter a value:

I enter my value and then it runs refresh nicely through refresh state, but when it should start doing actual changes, then:
Error refreshing state:

• 1 error(s) occurred:

* No valid credential sources found for AWS Provider.
Please see https://terraform.io/docs/providers/aws/index.html for more information on
providing credentials for the AWS Provider

[hatt]

Seeing the same as @evilezh, extra confusing when the provider is repeatedly asking which region to use with no context as to which module instance it's even referencing. Running on 0.7.3-dev (git commit 70d9fe8).

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.