Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/fastly: Add support for Request Headers #6197

Merged
merged 3 commits into from
Apr 18, 2016
Merged

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 15, 2016

Request Headers let you conditionally manipulate the Headers for various types of requests from users, backends, and Fastly's caches. Here we add header to the config, and allow users to specify headers to manipulate and how.

Example header block that delete the http.x-amz-request-id header that comes from a request served by AWS S3:

  header {
    destination = "http.x-amz-request-id"
    type        = "cache"
    action      = "delete"
    name        = "remove x-amz-request-id"
  }

Reference:

// destroy it and create a new one. This is how Terraform works with nested
// sub resources, we only get the full diff not a partial set item diff.
// Because this is done on a new version of the configuration, this is
// considered safe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good note here! I think there are other APIs where we (still) have race conditions because of this behavior. Nice to have it explained out front here.

@phinze
Copy link
Contributor

phinze commented Apr 18, 2016

Solid. LGTM!

@catsby catsby merged commit 25f89c8 into master Apr 18, 2016
@stack72 stack72 deleted the f-fastly-headers branch April 21, 2016 23:22
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants