provider/fastly: Add Gzip rule support #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed only the commit that adds support to the resource - LGTM! I am presuming the new test case runs work as expected? I don't have a fastly account :) Would it be worth adding a test for flattenGzips? |
|
@catsby - in that case - this looks good :) Thanks for the test addition! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides new attribute
gzip, a set of gzip rules to apply to file types or extensions, or both.I've opened a support case with Fastly regarding their handling of empty
extensionsandcontent_typesparameters. Right now, if you send only one, the other will come back with a set of default values. Ex, sending just extensioncsswill return a rule with just thecssextension, but a default list ofcontent_types...For now we work around this while I wait to hear what they say about that, e.g. is it a bug that will be fixed or just how things work, and we can work around that when we hear back.