provider/aws: fixing some logic issues with the aws-instance resource #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The schema contained a few fields that where not marked as `computed`, while they were updated inside the resource. 2. While updating the `volume_size` it was doing so with a `string`, but in the schema this field is set as `int`. 3. The set func for calculating the hashes for the `block` set items, also used computed values to calculate the hash. As these values will not be in the config, but only in the state, this will always show as a diff. The solution is to only use the fields that aren’t computed in order to get consistent hashes. These where all issues before, but weren’t visible as such. All should be good again now.
svanharmelen
pushed a commit
that referenced
this pull request
Dec 25, 2014
provider/aws: fixing some logic issues with the aws-instance resource
pmoust
added a commit
to PeoplePerHour/terraform
that referenced
this pull request
Dec 25, 2014
|
Great! Thanks. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computed, while they were updated inside the resource.volume_sizeit was doing so with astring, but in the schema this field is set asint.blockset items, also used computed values to calculate the hash. As these values will not be in the config, but only in the state, this will always show as a diff. The solution is to only use the fields that aren’t computed in order to get consistent hashes.These where all issues before, but weren’t visible as such. All should be good again now.