Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_launch_configuration: block_device support #756

Closed
xueshanf opened this issue Jan 8, 2015 · 10 comments
Closed

aws_launch_configuration: block_device support #756

xueshanf opened this issue Jan 8, 2015 · 10 comments

Comments

@xueshanf
Copy link

xueshanf commented Jan 8, 2015

Thanks to add block_device support for aws_instance resource. Any plan to add to aws_launch_configuration?

@skippy
Copy link

skippy commented Jan 16, 2015

+1

@jschneiderhan
Copy link
Contributor

Has anyone made any progress on this yet? I have a branch with it almost working https://github.com/jschneiderhan/terraform/tree/block-device-mapping-launch-configuration, but it istn't quite there. It creates the Launch Configuration with the Block Device Mappings, and I can see the DeviceName/VolumeSize/etc. in the AWS console, but on subsequent terraform plan calls it keeps trying to modify it, so I must be doing something wrong:

-/+ module.jschneiderhan.aws_launch_configuration.test
    ...
    block_device.1139171820.delete_on_termination: "" => "1" (forces new resource)
    block_device.1139171820.device_name:           "" => "/dev/sda1" (forces new resource)
    block_device.1139171820.encrypted:             "" => "<computed>" (forces new resource)
    block_device.1139171820.snapshot_id:           "" => "<computed>" (forces new resource)
    block_device.1139171820.virtual_name:          "" => "" (forces new resource)
    block_device.1139171820.volume_size:           "" => "150" (forces new resource)
    block_device.1139171820.volume_type:           "" => "<computed>" (forces new resource)
    ...

@jschneiderhan
Copy link
Contributor

It looks like the problem that I was having with that branch is related to a different issue (#913). I submitted the updates as a #935, although it's dependent on mitchellh/goamz#210 so it's currently marked as DON'T MERGE.

@josh-padnick
Copy link

+1 on this feature. Unfortunately, because Launch Configurations in AWS are copy-only, and because they immediately start launching EC2 instances in my AutoScalingGroup, trying to script around this temporarily with, for example, Boto, won't work unless I hardcode the AWS resource ID's. In my case, I was not able to use Terraform solely because this feature is missing. 😞

@xuwang
Copy link
Contributor

xuwang commented Mar 12, 2015

+1 on this feature.

@ketzacoatl
Copy link
Contributor

+1

@catsby
Copy link
Contributor

catsby commented Mar 30, 2015

I believe #1271 is a pull request for this, agree?

@jschneiderhan
Copy link
Contributor

@catsby correct. #935 was the original PR, but it's since become out of date. @jwaldrip was awesome enough to fork it and bring it up to date #1271. I'm going to close #935 since #1271 is definitely the better PR at this point.

@catsby
Copy link
Contributor

catsby commented Mar 30, 2015

Closing this as well then in favor of #1271

@catsby catsby closed this as completed Mar 30, 2015
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants