Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Add allowed_address_pairs #8257

Merged
merged 1 commit into from
Aug 23, 2016
Merged

provider/openstack: Add allowed_address_pairs #8257

merged 1 commit into from
Aug 23, 2016

Conversation

FedericoCeratto
Copy link

Based on #5076

@jtopjian
Copy link
Contributor

@FedericoCeratto Thanks for this. Let me know when this is ready for a review. :)

@FedericoCeratto
Copy link
Author

@jtopjian the PR is essentially ready as it is, unless acceptance tests are required (I'm having some trouble running the tests)

@jtopjian
Copy link
Contributor

It looks like you added a test for the import functionality, and I don't think that specific test is adding anything more to what was already being tested.

Acceptance tests are not required - I can always merge this and add one post-merge.

If this is ready to go, I'd say remove the import test and then squash everything into one commit.

@FedericoCeratto
Copy link
Author

@jtopjian the test was already in place, I populated the testAccNetworkingV2Port_basic variable.

@jtopjian
Copy link
Contributor

That's already done here so it's not required.

Original code from Rob Wilson <roobert@gmail.com>
@FedericoCeratto FedericoCeratto changed the title [WIP] Add allowed_address_pairs Add allowed_address_pairs Aug 18, 2016
@jtopjian
Copy link
Contributor

@FedericoCeratto sorry for the delay. Thank you very much for this!

@jtopjian jtopjian changed the title Add allowed_address_pairs provider/openstack: Add allowed_address_pairs Aug 23, 2016
@jtopjian jtopjian merged commit 9e4fc09 into hashicorp:master Aug 23, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants