Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Adding aws_ssm_document resource #8460

Merged
merged 2 commits into from
Aug 25, 2016
Merged

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 24, 2016

This takes the work by @liamjbennett in #8282 and makes the code review changes that @jen20 asked for

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMDocument_'                                          2 ↵ ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/25 09:23:31 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMDocument_ -timeout 120m
=== RUN   TestAccAWSSSMDocument_basic
--- PASS: TestAccAWSSSMDocument_basic (21.03s)
=== RUN   TestAccAWSSSMDocument_permission
--- PASS: TestAccAWSSSMDocument_permission (21.87s)
=== RUN   TestAccAWSSSMDocument_params
--- PASS: TestAccAWSSSMDocument_params (21.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    64.061s

@jen20
Copy link
Contributor

jen20 commented Aug 24, 2016

👍 from me now if the tests are passing and the build is OK.

@stack72
Copy link
Contributor Author

stack72 commented Aug 24, 2016

@jen20 tests are failing for duplicate resources - will look at this :)

@stack72 stack72 self-assigned this Aug 24, 2016
The changes are things like using d.Id rather than d.Get("name").(string)

and errwrap.Wrapf rather than fmt.Errorf
@stack72 stack72 merged commit 64510d9 into master Aug 25, 2016
@stack72 stack72 deleted the aws-ssg-document branch August 25, 2016 08:47
richardbowden pushed a commit to richardbowden/terraform that referenced this pull request Aug 27, 2016
* provider/aws: add `aws_ssm_document` resource

* provider/aws: Changes to `aws_ssm_document` post code review

The changes are things like using d.Id rather than d.Get("name").(string)

and errwrap.Wrapf rather than fmt.Errorf
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants