providers/aws: ignore ec2 root devices #877
Conversation
fixes #859 EC2 root block devices are attached automatically at launch [1] and show up in DescribeInstances responses from then on. By skipping these when recording state, Terraform can avoid thinking there should be block device changes when there are none. Note this requires that mitchellh/goamz#214 land first so the proper field is exposed. [1] http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/RootDeviceStorage.html
|
this looks good to me. 👍 as a side note, this same problem may occur with the ephemeral drives. I haven't tested it yet but you can see the notes in #858. |
|
yup! we'll just need to figure out the shape of the AWS API behavior there, but i'm definitely tracking that issue. in fact, i'll self-assign it now. |
|
LGTM. Great job. |
providers/aws: ignore ec2 root devices
|
@phinze nice. thanks. feel free to ping me if you need any context on that issue. i work remotely and i can make time for a hangout if you want to talk it through. |
|
Issue with this: #859 (comment) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
fixes #859
EC2 root block devices are attached automatically at launch [1] and show
up in DescribeInstances responses from then on. By skipping these when
recording state, Terraform can avoid thinking there should be block
device changes when there are none.
Note this requires that mitchellh/goamz#214 land
first so the proper field is exposed.
[1] http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/RootDeviceStorage.html