provider/aws: aws_db_option_group flattenOptions failing due to missing values #9052
Conversation
| "name": *j.Name, | ||
| "value": *j.Value, | ||
| }) | ||
| spew.Sdump("Option HERE %s", j) |
There was a problem hiding this comment.
looks like some extra debugging things here. In general it's OK to use spew in our tests, but we kind of made a decision to not include it in another files (so it won't ship with the Terraform binary as a dependency) .
Turns out spew is in some files, but I'll remove those 😆
There was a problem hiding this comment.
And that is the perfect reason why we send PRs for review :) Removed now so will merge on green
values Fixes #8332 Not all option_group parameters have values. For example, when you enable the MariaDB option_group, some of the settings have empty values (see screenshot) This PR adds a safety net on reading those values back to the statefile ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBOptionGroup_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/09/26 13:55:21 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBOptionGroup_ -timeout 120m === RUN TestAccAWSDBOptionGroup_importBasic --- PASS: TestAccAWSDBOptionGroup_importBasic (20.12s) === RUN TestAccAWSDBOptionGroup_basic --- PASS: TestAccAWSDBOptionGroup_basic (18.45s) === RUN TestAccAWSDBOptionGroup_basicDestroyWithInstance --- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (597.90s) === RUN TestAccAWSDBOptionGroup_OptionSettings --- PASS: TestAccAWSDBOptionGroup_OptionSettings (33.27s) === RUN TestAccAWSDBOptionGroup_sqlServerOptionsUpdate --- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (33.39s) === RUN TestAccAWSDBOptionGroup_multipleOptions --- PASS: TestAccAWSDBOptionGroup_multipleOptions (19.87s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 723.037s ```
stack72
force-pushed
the
b-aws-rds-option-group
branch
from
4f6ae5d to
df8ca94
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #8332
Not all option_group parameters have values. For example, when you
enable the MariaDB option_group, some of the settings have empty values
(see screenshot)
This PR adds a safety net on reading those values back to the statefile