Allow vpc_peering_connection

[julienba]

It's my first time writing go, so be careful.

At the moment, you need to create the peering connection with ami-cli or aws-console.
For a better integration it is required to improve https://github.com/mitchellh/goamz for creating the peering connection and link it into terraform

[julienba]

Link to mitchellh/goamz#220

[mitchellh]

This looks good! I noticed it doesn't support update. Is this true of the AWS resource? If so, you should set the RequiresNew: true parameter on all elements of the schema (except tags). You'll need an update to update the tags as well. Look at other resources for guidance!

[julienba]

You're right that I missed the update part and yes it's possible to update the tags.
I just add it

[mitchellh]

This looks really good!

[piavlo]

Btw why not to automatically accept the peering connection in case the peer and peering vpcs are managed by same aws account?

[julienba]

That should be possible. I will try to look at it it next week

[julienba]

@piavlo I've made a new PR with #1161

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.