Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/scaleway: update sdk for ams1 region #9687

Merged
merged 2 commits into from
Oct 28, 2016
Merged

provider/scaleway: update sdk for ams1 region #9687

merged 2 commits into from
Oct 28, 2016

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Oct 28, 2016

this PR updates the Scaleway SDK for the new announced Amsterdam 1 region.

Previously the Scaleway provider would error when using ams1 as region, because the SDK did not recognize the region yet.

@nicolai86
Copy link
Contributor Author

fixes scaleway/scaleway-cli#426

@nicolai86 nicolai86 changed the title provider/scalway: update sdk for ams1 region provider/scaleway: update sdk for ams1 region Oct 28, 2016
@nicolai86
Copy link
Contributor Author

\cc @tboerger

@tboerger
Copy link
Contributor

Cool, thanks!

@stack72
Copy link
Contributor

stack72 commented Oct 28, 2016

Actually, @nicolai86, this is a breaking change! We need to check the code here

Paul

@nicolai86
Copy link
Contributor Author

Interesting. I'll take a look asap to fix this

@stack72
Copy link
Contributor

stack72 commented Oct 28, 2016

nps :)

@nicolai86
Copy link
Contributor Author

yay, fixed. tiny SDK incompatability

@stack72 stack72 merged commit 082ef04 into hashicorp:master Oct 28, 2016
@nicolai86 nicolai86 deleted the provider-scaleway/update-sdk branch October 29, 2016 05:53
mathieuherbert pushed a commit to mathieuherbert/terraform that referenced this pull request Oct 30, 2016
* provider/scalway: update sdk for ams1 region

* provider/scaleway typecast volume size as of 472a493
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
* provider/scalway: update sdk for ams1 region

* provider/scaleway typecast volume size as of 472a493
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants