helper/schema: GetChange shouldn't return true when no change

[mitchellh]

Fixes #927

GetChange in helper/schema was just completely broken in some cases. This change seemed sketchy but nothing is failing and #927 is definitely fixed. I don't know why that getSourceExact was there before but I have a feeling it was likely due to weird behavior before my FieldReader refactor.

[phinze]

I don't know why that getSourceExact was there before but I have a feeling it was likely due to weird behavior before my FieldReader refactor.

Was changed explicitly in c755059 / #821 I'm reading that log right now.

[mitchellh]

@philk Yeah, the weird thing is that test still passes.

[mitchellh]

@phinze ^ I mean you.

Sorry @philk didn't mean to bring you in.

[phinze]

@mitchellh looks like past @mitchellh thought it was a good idea, and it was post FieldReader refactor.

This change LGTM generally, but you should double check with your past self to make sure there's nothing that strikes you. ⚡ 💡

[mitchellh]

Thanks for digging that up. I guess I just didn't question that exact, I only commented on the state part. I'm going to go with it and hope acceptance tests pick something wonky up.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.