add pull request template

[mjyocca]

Description

Add pull request template file to project

[CloudbrokerAz]

✅ Templates and Agent Updates Complete

Files Updated/Created

1. **** - Updated for module producer evaluation

   • Changed evaluation focus from consumer deployments to module publishing readiness
   • Updated dimensions: Variable Interface Design (25%), Security Defaults (30%), Output Interface Design (10%)
   • Changed readiness levels from "Production Ready" to "Ready to Publish"

2. **** (500 lines, completely rewritten)

   • Reframed from consumer deployment spec to module interface specification
   • Focus on: What problem does module solve for consumers? How will consumers use it?
   • Comprehensive sections: Variable Interface Design, Output Interface Design, Security Requirements, Testing Requirements, Example Requirements, Breaking Change Considerations

3. **** (649 lines, completely rewritten)

   • Reframed from infrastructure deployment planning to module architecture planning
   • Guides module producers through: Research & Discovery, Module Architecture Design, Implementation Details, Quality Checklist, Publishing Strategy
   • Focus on consumer-friendly variable interface and security by default

4. **** (571 lines, NEW)

   • Comprehensive template for major version upgrade guides
   • 7-step migration process with rollback procedures
   • Sections: Breaking Changes Detail, Step-by-Step Migration, Rollback Procedure, Common Issues, Help & Support

Commit: 8b8ea8e - "feat: update Claude templates and agents for module producer workflow"

Key Philosophy Changes

Consumer → Producer Mindset Shift:

• Old: "How do I deploy this infrastructure?"
• New: "How will consumers use my module?"

Examples of Producer-Focused Design:

• Variables are now the PRIMARY CONTRACT with consumers
• Security by default (encryption enabled, not optional)
• Testing pyramid: many fast unit tests (<10s), few slow integration tests
• Examples are critical (basic/ and complete/ demonstrate usage)

Next Steps

• Create module-specific commands (/module-init, /module-test, etc.)
• Review speckit agents (minimal changes expected)
• Final commit and close issue

Progress: ~70% complete for Issue #3