Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for secret encoding? #106

Closed
schantaraud opened this issue Aug 24, 2021 · 5 comments
Closed

Support for secret encoding? #106

schantaraud opened this issue Aug 24, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@schantaraud
Copy link

It seems that a common way of storing non-Unicode secrets in Vault is to base64-encode them. Is there currently a way to mount these through the CSI provider without adding a manual decoding process?
If not, the Azure driver supports an objectEncoding property (see Azure/secrets-store-csi-driver-provider-azure#236). Would you accept a PR that adds a similar feature?

@tomhjp
Copy link
Contributor

tomhjp commented Aug 26, 2021

Hi @schantaraud, thanks for opening this issue. There's no support for this currently, but you're not the first to express interest so I would definitely be open to receiving a PR for it. I think the design of the linked PR broadly looks like a good fit for this project too.

@tomhjp tomhjp added enhancement New feature or request good first issue Good for newcomers labels Aug 26, 2021
@therealsamlin
Copy link

therealsamlin commented Oct 13, 2021

In search of this functionality too. We're storing certs in vault as base64 encoded string and it's getting base64 encoded again when created as a k8 Secret object via SecretProviderClass.

Better yet it might help having a functionality that base64 decodes vault secret

@bimtauer
Copy link

bimtauer commented Jul 1, 2022

Same here, this would be great to have. We run some third party services that require certificates in pem string format but we have them base64 encoded everywhere else in Vault.

@LianwMS
Copy link

LianwMS commented Jul 13, 2022

@therealsamlin and @bimtauer, then how did you resolve such issue? We have the same issue here.

@tomhjp
Copy link
Contributor

tomhjp commented Apr 18, 2023

Fixed by #194. Thanks for the contribution @BroCanDo!

@tomhjp tomhjp closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants