Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent injector should set a maxSize for its tmpfs mount #526

Open
BojanZelic opened this issue Sep 28, 2023 · 0 comments
Open

Agent injector should set a maxSize for its tmpfs mount #526

BojanZelic opened this issue Sep 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@BojanZelic
Copy link

Is your feature request related to a problem? Please describe.
the vault agent injector currently adds some volumes using the Memory tmpfs filesystem:

  - emptyDir:
      medium: Memory
    name: vault-secrets

These don't have any limits set & kubernetes will default this to the node's allocatable memory; A user could add files to these directories eventually maxing out the underlying node's memory & crash the node;

Describe the solution you'd like
vault secrets don't take up much size; set a limit like 10M

  - emptyDir:
      medium: Memory
      sizeLimit: 10Mi
    name: vault-secrets

Describe alternatives you've considered
n/a

Additional context
see kubernetes/kubernetes#119611

@BojanZelic BojanZelic added the enhancement New feature or request label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant