Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance on calling ACL SAVE after Redis password rotation #25

Open
Tracked by #68
zboralski opened this issue Mar 29, 2023 · 2 comments
Open
Tracked by #68

Guidance on calling ACL SAVE after Redis password rotation #25

zboralski opened this issue Mar 29, 2023 · 2 comments

Comments

@zboralski
Copy link

Hi there! I'm a user of the vault-plugin-database-redis plugin and I'm wondering what the best practice is to ensure that the Redis ACL is updated after a password rotation. I've read that calling ACL SAVE is necessary to persist the changes to disk, but I'm not sure how to incorporate that into my workflow.

Could you please provide some guidance on how to properly call ACL SAVE after the plugin rotates the Redis password? Are there any examples or best practices that you could share with me?

Thank you for your help!

@zboralski
Copy link
Author

zboralski commented Mar 29, 2023

I guess it is probably more secure to just reconfigure database/config/redis and force database/rotate-root/redis when redis restarts?

Really not sure what's the best way to do this

@fhitchen
Copy link
Contributor

Hi Zboralski,
Sorry I am a bit late on answering your question. The cluster-support branch implements saving the ACL updates, either to and ACL file with ACL SAVE or to the config file with CONFIG REWRITE, you get to choose.
I am merging this branch into main so it should be easy for you to add the `persistence_mode' flag to the plugin initialization phase.
regards, Francis.

@fhitchen fhitchen mentioned this issue May 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants