Avoid race detector in test

Author: Christopher Swenson

builtin/logical/database/rotation_test.go

@@ -385,19 +385,6 @@ func TestBackend_StaticRole_Rotation_Schedule_ErrorRecover(t *testing.T) {
 		// should match because rotations should not occur outside the rotation window
 		t.Fatalf("expected passwords to match, got (%s)", checkPassword)
 	}
-	if len(eventSender.Events) == 0 {
-		t.Fatal("Expected to have some events but got none")
-	}
-	// check that we got a rotate-fail event
-	found := false
-	for _, event := range eventSender.Events {
-		if string(event.Type) == "database/rotate-fail" {
-			found = true
-			break
-		}
-	}
-	assert.True(t, found)
-
 	// Verify new username/password
 	verifyPgConn(t, username, checkPassword, connURL)
 
@@ -425,7 +412,20 @@ func TestBackend_StaticRole_Rotation_Schedule_ErrorRecover(t *testing.T) {
 	// Verify new username/password
 	verifyPgConn(t, username, checkPassword, connURL)
 
+	eventSender.Stop() // avoid race detector
 	// check that we got a successful rotation event
+	if len(eventSender.Events) == 0 {
+		t.Fatal("Expected to have some events but got none")
+	}
+	// check that we got a rotate-fail event
+	found := false
+	for _, event := range eventSender.Events {
+		if string(event.Type) == "database/rotate-fail" {
+			found = true
+			break
+		}
+	}
+	assert.True(t, found)
 	found = false
 	for _, event := range eventSender.Events {
 		if string(event.Type) == "database/rotate" {

sdk/logical/events_mock.go

@@ -12,7 +12,8 @@ import (
 // meant to be used in testing. It is thread-safe.
 type MockEventSender struct {
 	sync.Mutex
-	Events []MockEvent
+	Events  []MockEvent
+	Stopped bool
 }
 
 // MockEvent is a container for an event type + event pair.
@@ -25,10 +26,18 @@ type MockEvent struct {
 func (m *MockEventSender) SendEvent(_ context.Context, eventType EventType, event *EventData) error {
 	m.Lock()
 	defer m.Unlock()
-	m.Events = append(m.Events, MockEvent{Type: eventType, Event: event})
+	if !m.Stopped {
+		m.Events = append(m.Events, MockEvent{Type: eventType, Event: event})
+	}
 	return nil
 }
 
+func (m *MockEventSender) Stop() {
+	m.Lock()
+	defer m.Unlock()
+	m.Stopped = true
+}
+
 var _ EventSender = (*MockEventSender)(nil)
 
 // NewMockEventSender returns a new MockEventSender ready to be used.