Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable argument in variable block not properly highlighted #1286

Closed
renzepost opened this issue Dec 2, 2022 · 3 comments · Fixed by hashicorp/syntax#49
Closed

Nullable argument in variable block not properly highlighted #1286

renzepost opened this issue Dec 2, 2022 · 3 comments · Fixed by hashicorp/syntax#49
Assignees
Labels
bug Something isn't working syntax

Comments

@renzepost
Copy link

Versions

Extension

v2.25.1

VS Code

1.73.1

Operating System

Windows 10 Version 20H2 (OS Build 19042.2251) with WSL2: Ubuntu 20.04.5 LTS
Ubuntu 22.04.1 LTS

Terraform Version

v1.3.5
on linux_amd64

Steps To Reproduce

variable "foo" {
  description = "bar"
  nullable    = true
}

Expected Behavior

Entire keyword "nullable" is highlighted

Actual Behavior

The first character "n" is not highlighted but the rest of the keyword is.
image

Additional context

I'm using WSL2 in Windows 10 but I also managed to reproduce the issue on my machine running Ubuntu 22.04.1 LTS

@renzepost renzepost added the bug Something isn't working label Dec 2, 2022
@radeksimko
Copy link
Member

Reproduced, thank you for the report. This appears to be a bug in our highlighting grammar.

As we don't yet support nullable variables in the language server, this isn't covered by the semantic highlighting.

@dbanck
Copy link
Member

dbanck commented Dec 15, 2022

We just released the bug fix for this as part of the v2.25.2 extension release.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working syntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants