Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-languageclient to v8.0.2 #1311

Closed
1 of 2 tasks
jpogran opened this issue Jan 3, 2023 · 2 comments · Fixed by #1327
Closed
1 of 2 tasks

Update vscode-languageclient to v8.0.2 #1311

jpogran opened this issue Jan 3, 2023 · 2 comments · Fixed by #1327
Assignees
Labels
enhancement New feature or request

Comments

@jpogran
Copy link
Contributor

jpogran commented Jan 3, 2023

Background

As of v8.0.0 the vscode-languageclient library has put significant work into stabilizing and cleaning up the LanguageClient API.

Most relevant to us immediately is the cleanup of the start and stop methods which resulted in the collapsing the start and onReady methods to one single start method. This will reduce the number of places we need to track error handling (the varying places we activate) and whether or not the LS is "ready" yet before requesting a command (terraform-ls commands like Module View bar).

Also of note is a change to how ErrorHandler functions, which allows us to return a message to the user when the extension fails to activate. This should help with situations like #1301 by helping us produce more exact and timely error messages.

This requires us to bump the minimum engine version from 1.65.2 to 1.67.0. Looking back at the last 30 days of usage, over 90% of our users are on 1.70 or newer so this should not be a disruptive update.

Proposal

  • Bump the minimum engine version from 1.65.2 to 1.67.0
  • Update to v8.0.2 of vscode-languageclient
@jpogran jpogran added the enhancement New feature or request label Jan 3, 2023
@jpogran jpogran linked a pull request Mar 2, 2023 that will close this issue
@jpogran jpogran self-assigned this Mar 2, 2023
@jpogran
Copy link
Contributor Author

jpogran commented Mar 2, 2023

Finished in #1327

@jpogran jpogran closed this as completed Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant