Declare support for Terraform Stacks #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
changed the title
jpogran
force-pushed
the
tfstacks
branch
3 times, most recently
from
9a6175d
to
f90eb97
Compare
dbanck
requested changes
Jun 12, 2024
This begins the process of adding support for tfstack and tfdeploy files by declaring the file extensions and language identifiers in the package.json file. This will allow the extension to recognize these files and provide syntax highlighting and other language features. Future work will add icons and other features to fill out support. Of particular note is the aliases used for tfstack.hcl and tfdeploy.hcl files. These aliases are used to provide a more user-friendly name for the language in the VS Code status bar and other places where the language name is displayed. Getting these aliases right is not only important from a branding perspective but also from a user experience perspective. They have to be readable and understandable in a small amount of space.
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
ansgarm
reviewed
Jun 12, 2024
ansgarm
approved these changes
Jun 18, 2024
dbanck
approved these changes
Jun 18, 2024
jpogran
added a commit
that referenced
this pull request
Jun 25, 2024
* Declare support for tfstack and tfdeploy files This begins the process of adding support for tfstack and tfdeploy files by declaring the file extensions and language identifiers in the package.json file. This will allow the extension to recognize these files and provide syntax highlighting and other language features. Future work will add icons and other features to fill out support. Of particular note is the aliases used for tfstack.hcl and tfdeploy.hcl files. These aliases are used to provide a more user-friendly name for the language in the VS Code status bar and other places where the language name is displayed. Getting these aliases right is not only important from a branding perspective but also from a user experience perspective. They have to be readable and understandable in a small amount of space.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins the process of adding support for tfstack and tfdeploy files by declaring the file extensions and language identifiers in the package.json file. This will allow the extension to recognize these files and provide syntax highlighting and other language features. Future work will add icons and other features to fill out support.
Of particular note is the aliases used for tfstack.hcl and tfdeploy.hcl files. These aliases are used to provide a more user-friendly name for the language in the VS Code status bar and other places where the language name is displayed. Getting these aliases right is not only important from a branding perspective but also from a user experience perspective. They have to be readable and understandable in a small amount of space.