Remove snippets file in favor of terraform-ls #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the static snippets file in favor of using the Terraform Language Server to provide snippets completions. The file was a legacy feature from when there was no language server to provide more specific snippets. These snippets used the existing VS Code api to provide a minimal completion experience, but there was no facility to control when or where these snippets appeared. This frequently caused confusion for users as the snippets in the file were not always relevant to the current context and could not be disabled. The Terraform Language Server provides a more powerful and context-aware completion experience that can suggest completions for all Terraform language constructs. This is combined with the `editor.suggest.preview` and `terraform.experimentalFeatures.prefillRequiredFields` settings to provide a more accurate and helpful completion experience.
jpogran
force-pushed
the
remove_snippets_file
branch
from
ed9fe0e
to
a284779
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the static snippets file in favor of using the Terraform Language Server to provide snippets completions.
The file was a legacy feature from when there was no language server to provide more specific snippets. These snippets used the existing VS Code api to provide a minimal completion experience, but there was no facility to control when or where these snippets appeared. This frequently caused confusion for users as the snippets in the file were not always relevant to the current context and could not be disabled.
The Terraform Language Server provides a more powerful and context-aware completion experience that can suggest completions for all Terraform language constructs. This is combined with the
editor.suggest.previewandterraform.experimentalFeatures.prefillRequiredFieldssettings to provide a more accurate and helpful completion experience.