Stuck on Running 'HashiCorp Terraform' Formatter

[shinebayar-g]

Extension Version

v2.33.0

VS Code Version

Version: 1.95.2 (Universal)
Commit: e8653663e8840adaf45af01eab5c627a5af81807
Date: 2024-11-07T11:07:22.054Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.1.0

Operating System

24.1.0 Darwin Kernel Version 24.1.0

Terraform Version

Terraform v1.9.8 on darwin_arm64

Steps to Reproduce

We have a few thousand resources in our state and the extension just never works reliably. I have "editor.formatOnSave": true, enabled and whenever I save a file it just hang on Running 'HashiCorp Terraform' Formatter

Expected Behavior

VSCode Extension works reliably

Actual Behavior

It just hangs

Terraform Configuration

No response

Project Structure

No response

Gist

No response

Anything Else?

Zed Terraform extension works fine and doesn't have this problem. I think it's not a language server issue at least.

Workarounds

No response

References

No response

Help Wanted

• I'm interested in contributing a fix myself

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[mb-lakera]

Same here. Since recently it just started to hang when saving:

[dbanck]

Thank you both for reporting this!

This issue may be related to this one: hashicorp/terraform-ls#1857, so downgrading to the previous extension version may be a workaround for now.

To confirm a theory, are you by any chance using the AWS provider?

[mb-lakera]

Thank you for your response, I'll give it a try

are you by any chance using the AWS provider?

Yes, I do

[arl-lakera]

thanks @dbanck ! Same here, I am using the AWS provider.

[shinebayar-g]

Thank you both for reporting this!

This issue may be related to this one: hashicorp/terraform-ls#1857, so downgrading to the previous extension version may be a workaround for now.

To confirm a theory, are you by any chance using the AWS provider?

Thanks for the suggestion. I have downgraded to version 2.32.3 for now. I'll observe if it helps.

I use GCP provider.

[shinebayar-g]

Update: Extension 2.32.3 is noticeably better. It reduced the indefinite loading spinner to around 7~8 seconds (not always?) for me.

[mb-lakera]

Same here, so far 2.32.3 works fine. It does take sometimes quite a few seconds, but that is not a problem in comparison to the hanging 2.33.0

[shinebayar-g]

Update: I tried installing the https://github.com/hashicorp/terraform-ls/ by myself and set the "terraform.languageServer.path": "/opt/homebrew/bin/terraform-ls" in the vscode extension settings. It's performing much better.

Nah it's still hit and miss.

[dbanck]

We have released a new version of vscode-terraform: 2.34.1, which includes many bug fixes and some performance improvements (hashicorp/hcl-lang#426 being the most significant).
The update should show up automatically in VS Code.

Please let us know if it solves (or improves) the issues you were experiencing. I tried the new version on an older Celeron box with some sample configurations and it felt similar to 2.32.3.

[shinebayar-g]

Hi @dbanck , thanks for the update. It's working much better compared to previous versions.

I've noticed that some resources' Go to Definition is not working when they're updated. Could this be related to the recent changes? Otherwise, great improvement!

[dbanck]

Thanks for the quick feedback!

Do you mind opening a new issue for the Go to Definition problem you are seeing? This will allow us to dig into this separately.

[shinebayar-g]

Sure, will do if I can reproduce the exact steps. This is already so much better and usable. Thanks for the fix.