Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color highlight broken for terragrunt git example #492

Closed
bedge opened this issue Oct 1, 2020 · 2 comments
Closed

Color highlight broken for terragrunt git example #492

bedge opened this issue Oct 1, 2020 · 2 comments
Labels
bug Something isn't working syntax

Comments

@bedge
Copy link

bedge commented Oct 1, 2020

As this is the base "getting started" page for terragrunt, I'm using it to illustrate the problem.

I have the terraform plugin version 2.2.3

Version: 1.50.0-insider
Commit: 0c50e1db17168a738235bd7e5c02b9f05ea5df59
Date: 2020-09-30T06:45:45.996Z (1 day ago)
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 19.6.0

For this file: https://github.com/gruntwork-io/terragrunt-infrastructure-live-example, the highlighting is broken for everything after line 42, which seems to be a matter of ignoring a close quote:

Screen Shot 2020-10-01 at 12 34 02 PM

If one deletes the close quote on line 42, the highlighting is OK:

Screen Shot 2020-10-01 at 12 34 54 PM

Well, OK, to be more specific, it's still broken as it's not highlighting the fact that there's a missing close quote.

@dbanck dbanck added the bug Something isn't working label Feb 1, 2022
@dbanck
Copy link
Member

dbanck commented Feb 1, 2022

Thanks for raising this issue.

At some point in the past, the extension falsely claimed to offer syntax highlighting for .hcl files, too. As Terraform itself does not use the .hcl suffix, we removed this with the release of 2.0.0.

We do have plans to publish a more generic grammar as per #638, and it is likely that this grammar would replace the existing one. However, even then, such grammar would - in the context of this (Terraform) extension - would still be used to highlight Terraform code, not any other HCL (i.e., not Terragrunt).

With that in mind, I'm going to close this PR. Thanks for your understanding.

@dbanck dbanck closed this as completed Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working syntax
Projects
None yet
Development

No branches or pull requests

3 participants