Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear, persistent warning message #544

Closed
oliversalzburg opened this issue Jan 19, 2021 · 2 comments
Closed

Unclear, persistent warning message #544

oliversalzburg opened this issue Jan 19, 2021 · 2 comments

Comments

@oliversalzburg
Copy link

oliversalzburg commented Jan 19, 2021

Alternative root modules found for terraform/modules/ami (terraform/fairmanager/website), picked: terraform/modules/ami. You can try setting paths to root modules explicitly in settings.

I don't know what this message is trying to tell me. I have already configured root modules explicitly. Why does it keep popping up and requires me to close it? This is horrible UX.

I'd really love to see this pointless noise moved to an output channel, where it could be accompanied by the relevant explanation why the extension believes something is not working as designed, even though everything I care about works fine.

Your overuse of notification dialogs is ridiculous and the VS Code extension developer guidelines specifically note not to do that.

You have the status bar and output channels. Use those.

@oliversalzburg
Copy link
Author

Upon investigation, it's the language server itself calling right into the VS Code API to show GUI messages. There also seems to be overlap in what both components handle. Either way it's a terraform-ls issue.

@ghost
Copy link

ghost commented Feb 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant