Format-on-Save Stopped Working?

[davaba86]

Hi,

Recently my format-on-save stopped working and I've checked the docs however nothing new that I can see that I need to adjust in case of an update.

Here's my tf-related config.

"[terraform]": {
  "editor.formatOnSave": true,
  "editor.tabSize": 4,
},

VSCode TF Version: v2.13.0

Anyone else having these issues or might know what I can adjust?

[politician]

Yes I have the same issue!

[politician]

Actually after running more tests, I realize that even formatting won't work if you "Add a folder to workspace" in VS Code. So in my case it was a duplicate of #685

[radeksimko]

As @politician mentioned there is some likelihood this was caused by the bug which was fixed in #688

I just released that bug fix as part of v2.13.1. Can you try upgrading to that version and confirm it resolved the mentioned issues? If not I am happy to reopen and investigate. Thanks.

[davaba86]

Cheers, glad to hear a fix is on its way on the case you pointed to! :)

[radeksimko]

That new release should already be available in VS Code Marketplace (you may need to restart VS Code for it to show) - let me know if that resolved the issues.

[davaba86]

Yeah, I just updated and it works like a charm! :)

I did however had to force it since for some reason another extension (prettier) was taking over.

"[terraform]": {
  "editor.defaultFormatter": "hashicorp.terraform",
  "editor.formatOnSave": true,
  "editor.tabSize": 2,
},

[radeksimko]

Thank you for that extra context @david-abarca - this is helpful!

Unfortunately it's not the first time that I see a weird bug being caused by conflicts between multiple extensions claiming terraform language. I raised #693 and also created #692

btw. that third line (tabSize) you have there has no effect because Terraform itself (terraform fmt) is quite opinionated in how it does formatting and doesn't allow for indentation style to be any different than prescribed (two spaces).

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.