This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
builtin/k8s: Include user defined labels on deploy and add name/version labels #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
commented
Feb 25, 2021
| "name": name, | ||
| }, | ||
| }, | ||
|
|
||
| Template: corev1.PodTemplateSpec{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Labels: map[string]string{ | ||
| "app": name, | ||
| "name": name, |
There was a problem hiding this comment.
Not sure where this is happening exactly, but it seems like we use name some where for the local release URL to resolve so maybe we leave this as is and include app too?
There was a problem hiding this comment.
That's a reasonable decision. I would add a comment to that effect for future-us.
krantzinator
approved these changes
Feb 25, 2021
This was referenced Feb 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a couple of changes and enhancements for a kubeernetes deploy:
nameto beapp. This fits with how we labelwaypoint-serverpod, and will fit what is expected for other services that integrate with k8s such as Istio https://istio.io/latest/docs/ops/deployment/requirements/#pod-requirementsversion, becauseversionis an expected key that k8s integrations expect to have (also used by Istio).Fixes #966