This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
cmd/waypoint-entrypoint: dump heap profile on SIGUSR1 #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
approved these changes
Mar 12, 2021
|
This helped us find a leak so I will merge this for now until we improve it one day later. |
mitchellh
added a commit
that referenced
this pull request
Mar 16, 2021
cmd/waypoint-entrypoint: dump heap profile on SIGUSR1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to dump a heap profile (in pprof format) when the entrypoint receives a SIGUSR1. The profile is written to the system temporary directory with a timestamp. The exact path that was dumped is logged.
I hope to use this to debug #1192 and any future issues.
In the future, the team mentioned it'd be really cool if the server can request this information from an entrypoint and we can potentially use that to debug weird deployments. I think that's a good idea, but this is a simple thing we can do now and backport safely so I'm opening this PR first.