Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

UI: hcl config input from project settings #1253

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Conversation

gregone
Copy link
Contributor

@gregone gregone commented Apr 2, 2021

new-project-from-ui.mp4

@github-actions github-actions bot added the ui label Apr 2, 2021
@mitchellh
Copy link
Contributor

Cool! This looks good. Technically, you can have a remote waypoint.hcl even without connecting it to a Git repository, but I don't really see the use case for that today so maybe this is fine for now and we'll reassess in a future version.

Base automatically changed from ui-git-settings-new-project to main April 6, 2021 16:36
@gregone gregone marked this pull request as ready for review April 6, 2021 17:11
Copy link
Contributor

@pearkes pearkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One question but not a blocker, may be intentional for now.

ui/app/components/app-form/project-settings.ts Outdated Show resolved Hide resolved
@gregone gregone merged commit c3f241b into main Apr 6, 2021
@gregone gregone deleted the ui-project-hcl-input branch April 6, 2021 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants