This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
{serverinstall/builtin}/nomad: Provide config values for memory and CPU #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! I think the thing we should check is if this is enough. We can run our Lambda GitOps demo through this, I can do that soon. |
|
@mitchellh - perfect! Thanks. Let me know and I'll update the default vars in the PR |
briancain
force-pushed
the
f/nomad-resources
branch
from
e90bcda
to
d60818c
Compare
briancain
force-pushed
the
f/nomad-resources
branch
from
d60818c
to
c2e7538
Compare
|
LGTM! |
This commit introduces config options to use when defining a Server and Runner nomad job config. If no option is specified, it will use the configured defaults for Waypoint. This commit also increases the default CPU in MHz to 200 and Memory in MB to 600 (double the default for Nomad tasks) Fixes #1302
briancain
force-pushed
the
f/nomad-resources
branch
from
8350ffb
to
6ee811f
Compare
This commit introduces a 'resources' stanza to allow users to configure CPU and Memory per-deploy. It uses the default resources if left unspecified.
briancain
changed the title
krantzinator
approved these changes
Apr 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces config options to use when defining a Server and
Runner nomad job config. If no option is specified, it will use the
configured defaults for Waypoint. This commit also increases the default
CPU in MHz to 200 and Memory in MB to 600 (double the default for Nomad
tasks)
It also introduces resources stanza for nomads deploy. Unlike the install for a server and runner, it sticks to the default resource size.
Fixes #1302