Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

internal/cli: version shows Waypoint server version #1364

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

mitchellh
Copy link
Contributor

@mitchellh mitchellh commented Apr 20, 2021

Fixes #1323

This augments waypoint version to show the server version when available. This fails gracefully if the connection fails or there is no Waypoint server available. This command uses an arbitrary 2 second timeout so it doesn't block for a very long time if the connection is not working or taking a long time (unlike the CLI for other operations which will wait much longer).

image

@mitchellh mitchellh added this to the 0.3.x milestone Apr 20, 2021
@mitchellh mitchellh requested a review from a team April 20, 2021 17:29
@github-actions github-actions bot added the core label Apr 20, 2021
@krantzinator
Copy link
Contributor

Did we want to include this on the --version flag also, or just on the command?

@mitchellh
Copy link
Contributor Author

Did we want to include this on the --version flag also, or just on the command?

Oh that does a different thing? Yes... yes... I'm gonna just fix that to call version so the behavior is the same.

@mitchellh
Copy link
Contributor Author

Done

Copy link
Contributor

@krantzinator krantzinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command to show the Waypoint server version
2 participants