This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add ability to write config into files #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
force-pushed
the
feature/config-files
branch
from
e23ce6c
to
d91fedb
Compare
Co-authored-by: Rae Krantz <8461333+krantzinator@users.noreply.github.com>
evanphx
force-pushed
the
feature/config-files
branch
from
f9891cc
to
e39ec98
Compare
evanphx
force-pushed
the
feature/config-files
branch
from
1b91383
to
03976d8
Compare
krantzinator
approved these changes
May 3, 2021
| @@ -2223,6 +2234,10 @@ message ConfigVar { | |||
| // It exists only to be referenced by other variables. | |||
| bool internal = 8; | |||
|
|
|||
| // Indicates that this is actually be written as a file, with the name | |||
There was a problem hiding this comment.
nit: confusing wording
mitchellh
suggested changes
May 3, 2021
Co-authored-by: Rae Krantz <8461333+krantzinator@users.noreply.github.com>
evanphx
force-pushed
the
feature/config-files
branch
from
b1bebdd
to
baa01fa
Compare
briancain
approved these changes
May 4, 2021
mitchellh
suggested changes
May 4, 2021
mitchellh
approved these changes
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a file block to
config {}which indicates paths and the contents to be stored at those paths within the application. This data is written by the entrypoint.This is draft while we discuss how to expose the signal selector configuration.