Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

builtin/k8s: use the resource manager #1528

Merged
merged 2 commits into from
May 24, 2021
Merged

builtin/k8s: use the resource manager #1528

merged 2 commits into from
May 24, 2021

Conversation

mitchellh
Copy link
Contributor

Fixes #1524

The main reason for this change is so that during errors we'll roll back and destroy the deployment.

@mitchellh mitchellh requested a review from a team May 22, 2021 01:42
evanphx
evanphx approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much nicer.

briancain
briancain approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the rollback deletion worked for me! 🎉

@mitchellh mitchellh merged commit 27dcaed into main May 24, 2021
@mitchellh mitchellh deleted the improvement/k8s-rm branch May 24, 2021 18:11
This was referenced Jun 7, 2021
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanphx evanphx evanphx approved these changes

@briancain briancain briancain approved these changes

@izaaklauer izaaklauer izaaklauer approved these changes

Assignees
No one assigned
Labels
plugin/k8s plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert the kubernetes platform to the resource manager
4 participants
@mitchellh @evanphx @briancain @izaaklauer