-
Notifications
You must be signed in to change notification settings - Fork 327
Conversation
a3b5e80
to
b7bd5a4
Compare
b7bd5a4
to
57c94d2
Compare
57c94d2
to
19de853
Compare
19de853
to
7e49de2
Compare
5fb0e2a
to
09dfe4e
Compare
9d48a99
to
dfad4e1
Compare
dfad4e1
to
436009e
Compare
4015d01
to
42afdbe
Compare
42afdbe
to
37f52f7
Compare
</Pds::Button> | ||
</Pds::HelpText> | ||
</div> | ||
{{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very glad to see this move outside of the <ul>
.
Technically I can’t approve this PR because I opened it, but it gets my 👍 nonetheless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻 I was able to build my own waypoint server container with the latest changes to test. Ran through a nomad jobspec and a k8s apply project and did a few waypoint ups for both.
37f52f7
to
c7aab05
Compare
c7aab05
to
23a26d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and the attention to detail is :chefskiss:
Some minor changes highlighted that I think we should make
{{#if (or this.isShowingDestroyed (not-eq deployment.state 4))}} | ||
<AppItem::Deployment @deployment={{deployment}} @latest={{group.deployments.[0]}} /> | ||
{{/if}} | ||
{{/each}} | ||
{{else}} | ||
<EmptyState> | ||
<p>There are no deployments to display for this app yet</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this text be in the translations/
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started moving some of the text in this deployments.hbs
file to the translations files, but @jgwhite said the checklist item about it on this PR was meant for the single deployment item template, not this overarching deployments template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the other text to the translation file. Jamie and I discussed this specific block of text yesterday and agreed the paragraph breaks make it a bit more of a complex situation. It's a little out of scope for this PR, so we can add this text to the localization texts some other time.
ui/app/templates/workspace/projects/project/app/deployments.hbs
Outdated
Show resolved
Hide resolved
23a26d7
to
76e5eff
Compare
What is this?
Addresses #1239
Adds the UI to display mutable deployments.
Mutable deployments are groups of deployment versions that utilize the same resources, where newer deployments in the same generation overwrite previous deployments (ie only latest version is deployed at the same deployment URL). This functionality was added to accommodate users' existing workflows.
What’s the plan?
{{t ...}}
helper for all textWhat does it look like?
How do I verify it?
yarn ember serve
http://localhost:4200/tests
http://localhost:4200
mutable-application
inmutable-project