This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Feature: status reporting for ALB releases #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaaklauer
commented
Jun 2, 2021
| @@ -304,9 +315,145 @@ func (r *Releaser) Release( | |||
| return &Release{ | |||
| Url: "http://" + hostname, | |||
| LoadBalancerArn: *lb.LoadBalancerArn, | |||
| TargetGroupArn: target.Arn, | |||
| Region: target.Region, | |||
There was a problem hiding this comment.
I needed the region to build the right client. Other plugins have this on their config. Not sure which pattern we prefer.
izaaklauer
commented
Jun 2, 2021
| ) (*sdk.StatusReport, error) { | ||
|
|
||
| if release.Region == "" { | ||
| log.Debug("Region is not available for this release. Unable to determine status.") |
There was a problem hiding this comment.
I have a feeling that we might hit this case in the upgrade path, where someone upgrades a server then tries to promote a deployment that didn't encode the region?
There was a problem hiding this comment.
This would be good to test, sounds like a correct assumption.
izaaklauer
commented
Jun 2, 2021
|
|
||
| var health sdk.StatusReport_Health | ||
|
|
||
| switch *tgHealth.TargetHealth.State { |
There was a problem hiding this comment.
Potentially a dangerous deference, but we seem to do it in other places and it's ok.
There was a problem hiding this comment.
Maybe leave a note above the switch?
izaaklauer
changed the title
izaaklauer
changed the title
krantzinator
approved these changes
Jun 2, 2021
briancain
suggested changes
Jun 2, 2021
|
|
||
| var health sdk.StatusReport_Health | ||
|
|
||
| switch *tgHealth.TargetHealth.State { |
There was a problem hiding this comment.
Maybe leave a note above the switch?
izaaklauer
force-pushed
the
feature/aws-alb/status
branch
from
84179b8
to
1391bf6
Compare
Also some logic simplification, conforming to protobuf naming convention, and improved terminal UI.
izaaklauer
force-pushed
the
feature/aws-alb/status
branch
from
1391bf6
to
08277d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements status reports for the aws alb releaser plugin. It waits briefly for the release's target group to finish initializing, then reports on the health of the targets.
A few caveats:
Tested with deployments from ec2 and lambda.