Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

cli: Fix incorrect command help output #1628

Merged
merged 2 commits into from
Jun 9, 2021
Merged

cli: Fix incorrect command help output #1628

merged 2 commits into from
Jun 9, 2021

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jun 9, 2021 •
edited
Loading

Currently:

$ waypoint hostname list -h
Usage: waypoint hostname delete HOSTNAME

Fix:

$ waypoint hostname list -h
Usage: waypoint hostname list

Also

$ waypoint hostname -h
...
    list        List all registered hostname.

Change registered hostname => registered hostnames.

@github-actions github-actions bot added the core label Jun 9, 2021
@lkysow lkysow changed the title Fix incorrect command help output cli: Fix incorrect command help output Jun 9, 2021
@briancain briancain requested a review from a team June 9, 2021 18:52
briancain
briancain approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻 Thanks for opening a pull request to fix this up 😄

@briancain briancain added this to the 0.4.x milestone Jun 9, 2021
@lkysow lkysow marked this pull request as ready for review June 9, 2021 19:02
@lkysow
Copy link
Member Author

lkysow commented Jun 9, 2021

No worries. @briancain should I merge it or will you?

@briancain
Copy link
Member

I got you 👍🏻

@briancain briancain merged commit fdc351d into main Jun 9, 2021
@briancain briancain deleted the lkysow-patch-1 branch June 9, 2021 19:06
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request Jun 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
0.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@lkysow @briancain