Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: display status report indicators on releases #1657

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented Jun 15, 2021

Why the change?

Closes #1590

What’s the plan?

  • Add <StatusBadge> to <AppCard::Release>
  • Add <StatusBadge> to <AppItem::Release>
  • Add <StatusBadge> to release detail page

What does it look like?

image

image

image

How do I verify it?

Using Mirage

  1. Check out the branch:
    git checkout ui/status-report-indicators-on-releases
  2. Boot the dev server
    cd ui && ember serve
  3. Visit the demo release list view
  4. Verify you see status badges
  5. Visit the demo release detail view
  6. Verify you see a status badge

For realsies

  1. Check out the branch:
    git checkout ui/status-report-indicators-on-releases
  2. Build the ember app
    (cd ui && make)
  3. Bundle the static assets
    make static-assets
  4. Build the dev server
    make docker/server
  5. Build the CLI
    make bin
  6. Install waypoint on your platform of choice, i.e.
    ./waypoint install -platform=kubernetes -accept-tos -k8s-server-image=waypoint:dev
  7. Open the UI
    ./waypoint ui -authenticate
    
  8. Try out an example app of your choice (i.e. kubernetes/nodejs)
  9. Verify you see status badges

@jgwhite jgwhite added this to the 0.4.x milestone Jun 15, 2021
@jgwhite jgwhite self-assigned this Jun 15, 2021
@jgwhite jgwhite force-pushed the ui/status-report-indicators-on-releases branch from 2916c59 to 8f5a218 Compare June 15, 2021 15:00
@jgwhite jgwhite marked this pull request as ready for review June 15, 2021 15:07
@jgwhite jgwhite requested a review from a team June 15, 2021 15:08
@briancain briancain self-requested a review June 15, 2021 15:09
Copy link
Contributor

@gregone gregone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about state vs status report badges

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good 😄

.changelog/1657.txt Outdated Show resolved Hide resolved
@jgwhite jgwhite force-pushed the ui/status-report-indicators-on-releases branch from 8f5a218 to 88b5ca6 Compare June 15, 2021 19:14
@jgwhite jgwhite force-pushed the ui/status-report-indicators-on-releases branch from 88b5ca6 to 7f18573 Compare June 15, 2021 19:16
@jgwhite jgwhite merged commit 5e1b685 into main Jun 16, 2021
@jgwhite jgwhite deleted the ui/status-report-indicators-on-releases branch June 16, 2021 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display status report indicators on releases
3 participants