Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Bug: remove Operation flags from runner-agent command. #1708

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

izaaklauer
Copy link
Contributor

From my reading, the Operation flags are not applicable to runner-agent.

Closes #1704

From my reading, the Operation flags are not applicable to runner-agent.

Closes #1704
@izaaklauer izaaklauer requested a review from a team June 24, 2021 17:28
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but looks great.

@@ -0,0 +1,4 @@
```release-note:bug
core/runner: prevent use of operation flags on `runner agent` command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cli: here is fine. We have to document these (I think on the list for the "0.5 cycle") but we try to make these more user-actionable rather than map directly to our package structure.

Per Mitchell's feedback. Makese sense!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: waypoint runner agent -remote panics
4 participants