-
Notifications
You must be signed in to change notification settings - Fork 327
ui: Incorporate pushed artifacts into build display #1840
Conversation
@almonk there’s a bit of a design challenge with this change. In this screenshot, we display both operations (build and push) in the build card and list items, and display the status of whichever is later (should be the push) as the overall status. The result is potentially a lot of icon duplication. My gut says this is not terrible but rather inelegant and I suspect the layout probably falls down in some edge cases. Would love your take when you get a change to look at it. |
8ee2f07
to
14b6981
Compare
Idea from @almonk: |
Reflecting on this, I think @almonk’s design suggestion make it realistic for this to land in |
14b6981
to
db437c9
Compare
db437c9
to
65fafb4
Compare
65fafb4
to
0c6f7ba
Compare
0c6f7ba
to
9925d95
Compare
9925d95
to
4c331d0
Compare
4c331d0
to
9f176be
Compare
Just noticed that we could do with applying the same logic to the build detail page. Going to add that in here. |
Addressed in f36048c |
Co-authored-by: Sabrina Ko <sabrina@hashicorp.com>
000f494
to
f36048c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Saw the demo video
Why the change?
Primarily to address #1287, though adding the foundations for artifact-awareness will likely be useful for other features.
Could we load pushed artifacts in a more efficient manner?
“Yes, but not yet…”
We’re currently exploring the idea of adding dedicated aggregate API methods for aspects of the UI such as this. Watch this space. Until we have such a thing, this load-and-cross-reference approach is the only one available.
What’s the plan?
<AppCard::Build>
<AppItem::Build>
What does it look like?
Obligatory video:
pushed-artifacts-demo-1080p.mov
How do I test it?
Using Mirage
For realsies
(cd ui && make)