internal/cli: waypoint login supports tokens #1848
Conversation
| // clientContext is always set to our actual context we used to | ||
| // create our client. So this will accurately grab non-flag based | ||
| // access i.e. loading our default context. | ||
| newContext = *c.clientContext |
There was a problem hiding this comment.
This also fixes a bug with OIDC, too.
|
|
||
| // If we have a login token, then we're just done cause that can be stored directly. | ||
| if _, ok := token.Kind.(*pb.Token_Login_); ok { | ||
| return c.flagToken, 0 |
There was a problem hiding this comment.
Super yak shave-y question, but wouldn't token here and on line 188 make more semantic sense?
There was a problem hiding this comment.
token is the full pb.Token structure, not the string-encoded token 😄
There was a problem hiding this comment.
Ah ok, so is the convertResp.Token on line 125 a different type then than the decodeResp.Token?
There was a problem hiding this comment.
I'm not familiar with the larger OIDC picture yet 🙈 Tomorrow! hah
There was a problem hiding this comment.
Yeah haha. This is just the token system APIs so no need to know OIDC. decodeResp decodes a string token into a *pb.Token and Convert just returns the string token (converted from an invite token).
|
Merging this since it fixes a bug with OIDC! |
mitchellh
force-pushed
the
feature/login-token
branch
from
c396fc6
to
99d9178
Compare
This builds on
waypoint loginintroduced in #1831 for OIDC to provide a much nicer token-based login experience.Prior to this, users had to use
waypoint context createand specifically had to use a login token with that. If they had an invite token, they first had to convert it usingwaypoint token exchange. This is all friction and not obvious to users (though the underlying machinery is important).Users can now use
waypoint loginwith just the server address and ANY token and the CLI automatically does the right thing. It checks if the token is an invite token and automatically exchanges it. It also infers all the TLS and server connection settings based on the hostname (same as OIDC).Demo
CleanShot.2021-07-13.at.10.55.13.mp4